iswa/budget-app
1
0
Fork 0
Code Issues Pull Requests 7 Actions Packages Projects Releases Wiki Activity

Normalize callback prop naming to on[Noun][Verb] convention #3

Merged
iswa merged 1 commits from event-taxonomy-normalizer into master 2026-03-20 08:32:12 -07:00
Conversation 0 Commits 1 Files Changed 2 +9 -7
iswa commented 2026-03-20 08:26:21 -07:00
Owner
Copy Link

Rename onAmountSave → onPaycheckAmountSave and onGenerate →
onPaycheckGenerate in PaycheckColumn to match the on[Noun][Verb]
pattern used by all other callback props (onBillPaidToggle,
onBillAmountSave, etc.). Document the convention in CLAUDE.md.

Nightshift-Task: event-taxonomy
Nightshift-Ref: https://github.com/marcus/nightshift

Rename onAmountSave → onPaycheckAmountSave and onGenerate → onPaycheckGenerate in PaycheckColumn to match the on[Noun][Verb] pattern used by all other callback props (onBillPaidToggle, onBillAmountSave, etc.). Document the convention in CLAUDE.md. Nightshift-Task: event-taxonomy Nightshift-Ref: https://github.com/marcus/nightshift
iswa added 1 commit 2026-03-20 08:26:22 -07:00
Normalize callback prop naming to on[Noun][Verb] convention 963652bc61 
Rename onAmountSave → onPaycheckAmountSave and onGenerate →
onPaycheckGenerate in PaycheckColumn to match the on[Noun][Verb]
pattern used by all other callback props (onBillPaidToggle,
onBillAmountSave, etc.). Document the convention in CLAUDE.md.

Nightshift-Task: event-taxonomy
Nightshift-Ref: https://github.com/marcus/nightshift
iswa merged commit d5326b359e into master 2026-03-20 08:32:12 -07:00
iswa deleted branch event-taxonomy-normalizer 2026-03-20 08:32:12 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
iswa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iswa/budget-app#3
Delete Branch "event-taxonomy-normalizer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?