iswa/budget-app
1
0
Fork 0
Code Issues Pull Requests 7 Actions Packages Projects Releases Wiki Activity

Remove duplicate utility code via shared formatting module #1

Merged
iswa merged 1 commits from dead-code/remove-duplicate-utilities into master 2026-03-20 08:31:12 -07:00
Conversation 0 Commits 1 Files Changed 9 +53 -94
iswa commented 2026-03-20 08:26:13 -07:00
Owner
Copy Link

Consolidate MONTH_NAMES, PALETTE, formatCurrency, formatCurrencyShort,
ordinal, and fmt into client/src/utils/formatting.js. Consolidate
CONFIG_KEYS into server/src/constants.js. All consumer files updated
to import from these shared modules. PaycheckView re-exports formatCurrency,
ordinal, and formatPayDate for backward compatibility with existing tests.

Nightshift-Task: dead-code
Nightshift-Ref: https://github.com/marcus/nightshift

Consolidate MONTH_NAMES, PALETTE, formatCurrency, formatCurrencyShort, ordinal, and fmt into client/src/utils/formatting.js. Consolidate CONFIG_KEYS into server/src/constants.js. All consumer files updated to import from these shared modules. PaycheckView re-exports formatCurrency, ordinal, and formatPayDate for backward compatibility with existing tests. Nightshift-Task: dead-code Nightshift-Ref: https://github.com/marcus/nightshift
iswa added 1 commit 2026-03-20 08:26:13 -07:00
Remove duplicate utility code via shared formatting module c69984898b 
Consolidate MONTH_NAMES, PALETTE, formatCurrency, formatCurrencyShort,
ordinal, and fmt into client/src/utils/formatting.js. Consolidate
CONFIG_KEYS into server/src/constants.js. All consumer files updated
to import from these shared modules. PaycheckView re-exports formatCurrency,
ordinal, and formatPayDate for backward compatibility with existing tests.

Nightshift-Task: dead-code
Nightshift-Ref: https://github.com/marcus/nightshift
iswa merged commit 6344a6f7d5 into master 2026-03-20 08:31:12 -07:00
iswa deleted branch dead-code/remove-duplicate-utilities 2026-03-20 08:31:12 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
iswa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iswa/budget-app#1
Delete Branch "dead-code/remove-duplicate-utilities"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?